fix: check for SecondaryAudio | Video#1259
Merged
Merged
Conversation
In some scenarios when working with NVX, a route is intended to use the secondary audio (NAX) path instead of the primary audio path. A route that's both `Video` and `SecondaryAudio` should be considered a dual-path route instead of a single path.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the routing logic to correctly classify routes as dual-path when both Video and SecondaryAudio flags are present.
- Key changes:
- Added an additional check for routes with both Video and SecondaryAudio flags.
- Modified the condition in GetRouteToSource to determine dual-path routing.
ndorin
previously approved these changes
Apr 24, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the routing logic to correctly detect a dual-path route when both Video and SecondaryAudio flags are set, addressing scenarios where the NAX path should be used.
- Updated the conditional in GetRouteToSource to include a dual-path check.
- Ensured legacy behavior remains for single signal types.
Comments suppressed due to low confidence (1)
src/PepperDash.Essentials.Core/Routing/Extensions.cs:72
- [nitpick] Consider assigning the dual-path check (signalType.HasFlag(eRoutingSignalType.Video) && signalType.HasFlag(eRoutingSignalType.SecondaryAudio)) to a descriptive variable, which can help improve readability and maintainability of the conditional logic.
if (!signalType.HasFlag(eRoutingSignalType.AudioVideo) &&
AECohn
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some scenarios when working with NVX, a route is intended to use the
secondary audio (NAX) path instead of the primary audio path. A route
that's both
VideoandSecondaryAudioshould be considered adual-path route instead of a single path.