Temp to dev#1260
Merged
Merged
Conversation
In some scenarios when working with NVX, a route is intended to use the secondary audio (NAX) path instead of the primary audio path. A route that's both `Video` and `SecondaryAudio` should be considered a dual-path route instead of a single path.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
fix: check for `SecondaryAudio | Video`
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refines the route selection logic in the GetRouteToSource extension method to properly handle cases with combined Video and SecondaryAudio flags.
- Updated the conditional check in GetRouteToSource for improved signal type filtering.
Comments suppressed due to low confidence (1)
src/PepperDash.Essentials.Core/Routing/Extensions.cs:72
- [nitpick] Consider extracting the compound condition into a well-named boolean variable or a dedicated method to improve readability and maintainability.
if (!signalType.HasFlag(eRoutingSignalType.AudioVideo) &&
ndorin
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.