Feature/add i has web view with pwa mode#1388
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds Progressive Web App (PWA) support to the webview functionality by introducing a new interface. The change extends the existing webview infrastructure to allow devices to manage PWA mode, including entering and exiting PWA mode with appropriate state feedback.
Changes:
- Added
IHasWebViewWithPwaModeinterface extendingIHasWebViewwith PWA mode properties and methods - Added properties for PWA mode state checking (
IsInPwaMode,IsInPwaModeFeedback) - Added methods for PWA navigation (
SendNavigatorsToPwaUrl,ExitNavigatorsPwaMode)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…w.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…w.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
andrew-welker
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new interface to extend webview functionality with support for Progressive Web App (PWA) mode. The main change is the addition of
IHasWebViewWithPwaMode, which provides properties and methods to manage PWA mode in devices implementing webview interfaces.Extension of webview interfaces:
IHasWebViewWithPwaModeinterface tosrc/PepperDash.Essentials.Core/DeviceTypeInterfaces/IHasWebView.cs, extendingIHasWebViewwith properties for checking PWA mode status (IsInPwaMode,IsInPwaModeFeedback) and methods to send navigators to a PWA URL and exit PWA mode.No functional changes:
src/PepperDash.Essentials.Core/DeviceTypeInterfaces/IHasWebView.cs.