Skip to content

fix(hotfix): skip CrestronOnvif.dll during assembly scanning at startup #1389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrew-welker merged 3 commits into from
Mar 3, 2026
Merged

fix(hotfix): skip CrestronOnvif.dll during assembly scanning at startup #1389

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a9fdf30
Initial plan
Copilot Mar 1, 2026
6ab3ed9
fix(hotfix): skip CrestronOnvif.dll when scanning assemblies at startup
Copilot Mar 1, 2026
b21be60
Update src/PepperDash.Essentials.Core/Factory/DeviceFactory.cs
ngenovese11 Mar 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/PepperDash.Essentials.Core/Factory/DeviceFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,17 @@ public DeviceFactory()
{
var programAssemblies = Directory.GetFiles(InitialParametersClass.ProgramDirectory.ToString(), "*.dll");

// Assemblies known to cause load errors that should be skipped
var assembliesToSkip = new[] { "CrestronOnvif.dll" };

foreach (var assembly in programAssemblies)
{
if (assembliesToSkip.Any(a => Path.GetFileName(assembly).Equals(a, StringComparison.OrdinalIgnoreCase)))
{
Comment thread
ngenovese11 marked this conversation as resolved.
Debug.LogMessage(LogEventLevel.Verbose, "Skipping assembly: {assemblyName}", Path.GetFileName(assembly));
continue;
}

try
{
Assembly.LoadFrom(assembly);
Expand Down