Skip to content

fix: resolve null currentScenario in manual only setup #1402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AECohn wants to merge 2 commits into from
Closed

fix: resolve null currentScenario in manual only setup #1402

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2cdb12
fix: calls scenario in SetRoomCombinationScenario preventing null fro…
AECohn Mar 20, 2026
e003e4d
fix: move ChangeScenario outside of loop, remove the discard modifier
AECohn Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/PepperDash.Essentials.Core/Room/Combining/EssentialsRoomCombiner.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,6 +446,8 @@ public void SetRoomCombinationScenario(string scenarioKey)
{
Debug.LogMessage(LogEventLevel.Debug, this, "Unable to find partition with key: '{0}'", partitionState.PartitionKey);
}
// Sets the scenario while disregarding the returned task. This prevents current scenario from being null when starting in manual mode.
_ = ChangeScenario(scenario);
}
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ChangeScenario(scenario) is currently executed inside the foreach (var partitionState ...) loop. That means the scenario may be activated/deactivated after only the first partition state is applied (and the call is redundantly invoked on every iteration, even if subsequent calls no-op). Move the scenario change call outside the loop (after all partition states have been set) so activation happens once and only after the partitions reflect the requested scenario.

Suggested change
// Sets the scenario while disregarding the returned task. This prevents current scenario from being null when starting in manual mode.
_ = ChangeScenario(scenario);
}
}
// Sets the scenario while disregarding the returned task. This prevents current scenario from being null when starting in manual mode.
_ = ChangeScenario(scenario);

Copilot uses AI. Check for mistakes.
}
else
Expand Down
Loading