fix: clean up unused using directives and add firmware version check …#1414
Merged
Conversation
…in ControlSystem Co-authored-by: Copilot <copilot@github.com>
andrew-welker
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a minimum firmware version check to the
ControlSystemclass inPepperDash.Essentials, ensuring that the application only runs on supported firmware. Additionally, it improves the logic for determining the WebSocket URL in dual-stack environments and performs a minor cleanup in theDebug.csfile.Firmware version enforcement:
minimumFirmwareVersionconstant and logic inControlSystem.InitializeSystem()to check the device firmware version at startup. If the firmware is below the required version (2.8006.00110), the system logs a fatal error and halts initialization. This prevents the application from running on unsupported hardware. [1] [2]Networking improvements:
Urlproperty inDebugWebsocketSinkto ignore invalid CSLAN IP addresses (e.g., "Invalid Value") and reliably select a reachable IP address in dual-stack environments.Code cleanup:
using System.Net;directive fromDebug.csto tidy up unused imports.…in ControlSystem