Repository navigation
release: merge v3 into dev for v3.10.0 - #260
Open
1Lucas1apk wants to merge 235 commits into
Open
1Lucas1apk wants to merge 235 commits into
1Lucas1apk wants to merge 235 commits into
Conversation
fix: handle object-form ipBlocks in routeplanner status
improve: reuse route planner ip block entry type
setDucking was declared in the route interface and already implemented on Player, but PlayerManager never got the bridging method, so toggling ducking crashed with a 500
fix: wire setDucking into PlayerManager
Moved bootstrap and server logic into their own modules. Cleaned up index.ts and simplified the startup and IPC flow. Removed unnecessary code, types and comments. 🚧 Cleanup #1
(All thanks to JustEvil because i just replicated this and put on your fixes lol) Fixes this error: Cannot read properties of null (reading 'canStop')
Refactored server initialization with synchronous constructor and 3-phase startup. Encapsulated monitor timers in WeakMap and delegated voice routing to VoiceRouter. Removed internal defensive checks and ghost properties. Delegated worker source caching and load updating to WorkerManager. 🚧 Cleanup #2
When useBunServer is enabled, createBunServer initializes Bun.serve(), which binds and starts listening immediately. Calling listenHttpServer afterwards caused a TypeError because Bun server instances do not have an .on() method.
fix: skip listenHttpServer when using native Bun server
If you want to select a specific lyrics source from the params you now can.
this should fix urls with extra queries failing to resolve
This should fix insta audios again (direct playback).
Mint a fresh PO token inline when the server reports limited playback, instead of tearing down the whole session. Full recovery now only runs after sustained failures or media stalls. Corrected the VideoPlaybackAbrRequest namings. Start bandwidth timing at first byte, excluding handshake. Merge contiguous buffer chunks sharing one backing store. The base i used for this commit (namings, contiguous buffer etc is from LuanRT/googlevideo#54, credits to him.)
YouTube audio now downloads in bigger pieces when the connection is healthy. After 3 clean responses it allows chunks up to 4 MB instead of stopping at 512 KB, and it drops back to 512 KB as soon as anything fails. It also checks how full the playback buffer is and asks for less when the buffer is nearly full. Fixed too: a 416 response in the middle of a track used to cut playback short. Now the stream only ends when the download is actually finished, otherwise it grabs a fresh link and keeps going.
Replace legacy encrypted flat-file disk persistence with native node:sqlite. Add shared WAL-mode database, automatic legacy file migration, and multi-tier LRU cache.
Remove pcmAnalysisRequest IPC channel, source analysis micro-worker, and Base64 PCM serialization across processes. Audio analysis is handled in-process via binary streams without IPC lag.
Implement IncrementalAnalysisEngine and ProgressiveAudioReader for streaming feature extraction with dynamic mathematical pacing. Add in-memory AutoMixCacheManager with LRU eviction and zero disk I/O.
Prevent auxiliary analysis streams from attaching active position callbacks or overwriting profilerStreamStats. Bypass redundant FFT processing during stream buffering and sanitize arming logs.
Remove verbose recovery info logs during source state transitions, retaining only actionable warnings for degraded and failing sources.
Bump development package version and rebuild distribution artifacts with tsc.
Use binary search O(log N) in _recalculateLyricsIndex and pace drift retries in _syncLyrics to prevent micro-timer cascades. Replace blocking zlib.gzipSync with async gzip in makeRequest, and unref server monitor interval timers.
Reduce aggressive 10ms fading ramp polling intervals to 40ms during pause and trackStop transitions, and unref drain and trackEnd timers. Bump development package version to 3.10.0-dev.2026-11-15.2.
Add unref to log rotation, connection manager, server monitor, worker stats update, and HLS handler retry timers.
Replace mp4box with Symphonia 1.3.0 for MP4 playback and seeking. Use the same addon in Eternalbox to extract AAC frames and their timestamps for the beat cache. Replace libsamplerate-js with Rubato through the Symphonia addon. FAAD2 still decodes AAC, and Rubato converts the decoded audio to 48 kHz stereo PCM. Release decoder and resampler resources when a track ends or is replaced. Read YouTube TV itag 18 streams in bounded HTTP ranges. This lets playback and seeking reach the MP4 metadata without downloading the whole video. Sequential MP4 playback requires moov before the media. Files with moov at the end need a playback path that uses HTTP Range. (some numbers, total 20 minutes of playback each, 25 playing players): mp4box + libsamplerate: avg around 1.1gb, and dint step out of this area. symphonia + libsamplerate: avg around 550/600mb symphonia + rubato: avg around 420/550mb this can vary, but this were the results i got while testing. Also, mp4 loading, seeking and its operations should be faster.
Add micro-yield with setImmediate before JSON.parse on response bodies larger than 64KB across HTTP/1 and HTTP/2 to prevent event loop stalls. Consolidate HLS playlist sequence extraction into a single loop pass.
Route getTrackUrl to specialized source workers using pure named pipes and unix domain sockets. Transmit binary V8 serialized frames without intermediate JSON parsing on player threads. Forward getTrackUrl requests from playback cluster workers through master command socket. Preserve fallback to local resolution if source workers are unavailable. Bump dev version to 3.10.0-dev.2026-11-15.5.
Add thread and worker PID telemetry when dispatching and resolving getTrackUrl. Log execution latency and protocol for source worker track resolutions. Rebase cleanly on top of origin/dev (5a1497a). Bump dev version to 3.10.0-dev.2026-11-15.6.
- Correct socket backpressure handling in commandSocket and sourceWorkerManager - Treat false return from socket write as buffered data rather than failure - Reject pending master requests on command socket disconnect without 60s timeout - Make hasAvailableWorkers dynamically evaluate command socket connection state - Replace Deezer literal setTimeout retry loop with cooperative setImmediate - Clean up dead _controlSocket reference and improve worker URL telemetry logging - Bump version to 3.10.0-dev.2026-11-15.7
- Force http1makeRequest for Deezer media streams to prevent HTTP/2 session timeout drops - Enlarge PassThrough buffer highWaterMark to 1MB to prevent player buffer starvation - Mark hosts in http2FailedHosts whenever HTTP/2 session terminates with error mid-stream - Bump version to 3.10.0-dev.2026-11-15.8
Pass Symphonia's AAC packets straight to FAAD2, skipping ADTS wrapping and frame scanning during playback and seeking.
Batch indexed audio ranges when the server supports multipart requests. Signal track completion when MP4 decoding finishes. In my playback test, a 242 MB MP4 started in under one second and increased NodeLink’s memory usage by about 1.4 MB. With MP4Box, the same file took much longer to start and increased memory usage from about 190 MB to 750 MB, then got back at 250mb after erroing 1 time and playing on the 2nd.
- Switch Deezer stream decryption to 32 KiB volume yield with setImmediate - Validate Blowfish-CBC chunk alignment and seek resumption bit-exactness - Handle isVolProtectedSupport flag to bypass protected volume and mixer - Restore and harden HTTP/2 connection pooling with auto HTTP/1 fallback
Skip the second resume call after reconnecting so a leftover audio timer cannot send packets after the UDP encryption key is cleared. (should fix UDP secretKey missing (udpInfo=false) errors)
For non-frame-aligned WAV data ranges, seek to the aligned PCM offset but discard leading padding bytes so Content-Range matches samples.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates the accumulated changes from
v3intodevas preparation for thev3.10.0release.This merge brings the existing development history together and establishes the next release baseline.
Release
Target version:
3.10.0Notes