Repository navigation
fix: player fade bugs - #262
Open
Akinori107 wants to merge 3 commits into
Open
Akinori107 wants to merge 3 commits into
Akinori107 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Why
a quick resume during the pause fade starts a second packet loop in the voice package so the track keeps playing while paused,
getEffectiveRateonly covers tape and scratch so the track end timer ignored timescale and tracks slower than 1x ended early, and the track end fade ignoredfading.enabledCheckmarks
Additional information
the player rework (#250) still has these bugs