Skip to content

fix: player fade bugs - #262

Open
Akinori107 wants to merge 3 commits into
PerformanC:devfrom
Akinori107:fix/player-fades
Open

Akinori107 wants to merge 3 commits into
PerformanC:devfrom
Akinori107:fix/player-fades

Conversation

@Akinori107

Copy link
Copy Markdown
Contributor

Changes

  • cancel the pending pause fade timer on resume
  • skip unpause when the connection is already playing and finish the resume there
  • use the configured timescale for the track end timer
  • skip the track end fade when fading is disabled

Why

a quick resume during the pause fade starts a second packet loop in the voice package so the track keeps playing while paused, getEffectiveRate only covers tape and scratch so the track end timer ignored timescale and tracks slower than 1x ended early, and the track end fade ignored fading.enabled

Checkmarks

  • The modified endpoints have been tested.
  • Used the same indentation as the rest of the project.
  • Still compatible with LavaLink clients.

Additional information

the player rework (#250) still has these bugs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant