Skip to content

fix: seek precision and paused seek, improve seek fade - #263

Open
Akinori107 wants to merge 3 commits into
PerformanC:devfrom
Akinori107:fix/seek
Open

Akinori107 wants to merge 3 commits into
PerformanC:devfrom
Akinori107:fix/seek

Conversation

@Akinori107

Copy link
Copy Markdown
Contributor

Changes

  • seek youtube webm with the cues index and drop the audio before the target in the demuxer
  • keep the player paused when seeking a paused player
  • fade out before seeking and bring the volume back if the seek fails

Why

the webm seek estimated the byte offset from the duration so it landed seconds away from the target while reporting the requested position, seeking while paused started playing the new stream, and the seek fade only faded in after a hard cut

Checkmarks

  • The modified endpoints have been tested.
  • Used the same indentation as the rest of the project.
  • Still compatible with LavaLink clients.

Additional information

i can remove the seek fade commit if preferred

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant