grok_bin_oct_hex: Cleanup #24043
Merged
grok_bin_oct_hex: Cleanup #24043
+90
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And reflow. This is in preparation for the next commit.
This makes the loop occupy less memory, but it's mainly for the next commit which will remove a conditional each time through the loop, and the tests want the error messages displayed in a particular order.
There are several code sections that deal with overflow; this allows some of them to be combined, in future commits
This rationalizes a bit more the code at the end of the function to make it a bit more readable.
This moves some code into an else, and replaces it with an UNLIKELY. That could be eliminated if we didn't care about the order the warning messages are raised, but the test suite does test for a particular order, so I'm leaving it as-is.
tonycoz
approved these changes
Jan 4, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This p.r. adds/clarifies comments and moves code out of a loop, allowing the collapsing of code sections that each deal with overflow.