Skip to content

Conversation

@khwilliamson
Copy link
Contributor

This panic croak was wrong, should it ever get executed. Any byte that reaches it isn't a digit, so %d would give wrong results.

  • This set of changes does not require a perldelta entry.

This panic croak was wrong, should it ever get executed.  Any byte that
reaches it isn't a digit, so %d would give wrong results.
@tonycoz
Copy link
Contributor

tonycoz commented Jan 4, 2026

I think this is a bad change.

If the panic ever happens and *s contains some control character the resulting panic message will display something like panic: scan_num, *s= followed by a probably invisible control character.

The %d provides something that's visible to the user and can be more easily be reported.

It may be that the message is difficult to reproduce, so we can't depend on the user being able to capture the message in a file and extract its character code that way.

@khwilliamson khwilliamson deleted the panic_format_fix branch January 5, 2026 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants