call_sv: check the runtime package to decide whether DB::sub is callable #24060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smartmatch uses call_sv() under the covers, this is a call to main::f from package DB which should not invoke DB::sub
Similar to Perl#24001 call_sv() was checking the current package being compiled to, typically main:: when nothing is being compiled, rather than the current runtime package. Unfortunately, init_debugger() uses PL_curstash to suppress DB::sub during initialization, so continue to check that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #24001 call_sv() was checking the current package being
compiled to, typically main:: when nothing is being compiled, rather
than the current runtime package.
Unfortunately, init_debugger() uses PL_curstash to suppress DB::sub
during initialization, so continue to check that