Adapt to SDL 3.2.24 #311
Open
Adapt to SDL 3.2.24 #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After upgrading SDL from 3.2.22 to 3.2.24 t/core.t started to fail
like this:
# Failed test '[get_error] got error '
# at t/core.t line 69.
# got: ''
# expected: anything else
# Looks like you failed 1 test of 28.
t/core.t ........................ Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/28 subtests
(3 TODO tests unexpectedly succeeded)
The failure is triggered by SDL 5594d03da086ab255b1d7ace1496f3a0c109a83d commit
("Leave letterbox borders set to the frame clear color").
SDL_SetVideoMode(640, 480, 232, SDL_ANYFORMAT) kept succeeding, but
SDL_GetError() stopped returning "rect has a negative size" error.
Because the new behavior is more consistent and because the Perl test
checks for SDL::get_error() instead of SDL::Video::set_video_mode()
return value, I conlude that the Perl test wants to test
SDL::get_error() and uses SDL::Video::set_video_mode() only as a way
to produce an error.
Thus this patch uses a different SDL::Video::set_video_mode()
arguments to obtain an error ("Invalid width or height").
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading SDL from 3.2.22 to 3.2.24 t/core.t started to fail like this:
The failure is triggered by SDL 5594d03da086ab255b1d7ace1496f3a0c109a83d commit ("Leave letterbox borders set to the frame clear color").
SDL_SetVideoMode(640, 480, 232, SDL_ANYFORMAT) kept succeeding, but SDL_GetError() stopped returning "rect has a negative size" error.
Because the new behavior is more consistent and because the Perl test checks for SDL::get_error() instead of SDL::Video::set_video_mode() return value, I conlude that the Perl test wants to test SDL::get_error() and uses SDL::Video::set_video_mode() only as a way to produce an error.
Thus this patch uses a different SDL::Video::set_video_mode() arguments to obtain an error ("Invalid width or height").