[codex] Add diagnostic bundle validation tests - #22
Open
xianxiye wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds deterministic diagnostic bundle validation coverage for the JSON/logd contract and fixes Windows metadata paths to use repository-relative
/paths.Changes
tools/verify_diagnostic_bundle.pyto validate diagnostic JSON/logd pairing.README.md.Testing
python -m py_compile build.py tools\verify_diagnostic_bundle.py tests\test_verify_diagnostic_bundle.pypython -m unittest discover -s tests -t . -vpython tools\verify_diagnostic_bundle.py diagnostic\build-00000000.jsonpython3 build.pyattempted; it stopped at frontend becausenpmis not installed in this Windows environment.python3 build.py -m backendgenerated the required diagnostic bundle but exited non-zero becausecargois not installed.python tools\verify_diagnostic_bundle.py diagnostic\build-0e5a90ec.jsonDiagnostics
diagnostic/build-0e5a90ec.jsondiagnostic/build-0e5a90ec-part001.logddiagnostic/build-0e5a90ec-part002.logd5bd4dc9f1b40d989ade8cat diagnostic/build-0e5a90ec-part001.logd diagnostic/build-0e5a90ec-part002.logd > diagnostic/build-0e5a90ec.logdChecklist