Fix height of rows with no drawn cells being ignored #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PgBiel
added
bug
With the old code, rows which had no cells to draw would have their heights skipped, leading to overlap with further rows or even with paragraphs after the table. This affected rowspans spanning all columns, since all rows other than the first would not be drawn at all, thus their heights would be ignored when sizing the table.
PgBiel
force-pushed
the
full-rowspan-sizing
branch
from
325b589 to
ed3b8cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was specific to the old renderer. The row heights were otherwise being calculated correctly.
Could affect Explicit use ofNope, the bug is still there. Likely not a renderer bug then.x(y) incellx(x: ...)causes table rows to be uneven whenrowsparameter is set #97