Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Knn query lacks inner_hits field #3101

Merged
merged 2 commits into from
Jul 6, 2024
Merged

Knn query lacks inner_hits field #3101

merged 2 commits into from
Jul 6, 2024

Conversation

apavlychev
Copy link
Contributor

Philippus
Philippus requested changes Jul 3, 2024
View reviewed changes
Copy link
Owner

@Philippus Philippus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test, showing how it works in practice?

@apavlychev
Copy link
Contributor Author

Could you add a test, showing how it works in practice?

added ChunkKnnTest tests with examples from https://www.elastic.co/guide/en/elasticsearch/reference/current/knn-search.html#nested-knn-search

@apavlychev apavlychev requested a review from Philippus July 5, 2024 10:02
@Philippus Philippus merged commit 43eec09 into Philippus:main Jul 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Philippus Philippus Awaiting requested review from Philippus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Knn query lacks inner_hits field
2 participants
@apavlychev @Philippus