Add and configure Maven Spotless plugin for formatting#124
Merged
PhilippvK merged 4 commits intoPhilippvK:masterfrom Nov 7, 2024
Merged
Add and configure Maven Spotless plugin for formatting#124PhilippvK merged 4 commits intoPhilippvK:masterfrom
PhilippvK merged 4 commits intoPhilippvK:masterfrom
Conversation
This ensures there is consistent formatting for the whole codebase. I opted to use Palantir's formatting standard as it's already pretty close to the codebase's format and is widely used elsewhere.
Done by manually running `mvn spotless:apply`. No functional changes.
This way the formatting from Spotless changes do not show up in `git blame`.
This will ensure that the codebase remains consistently formatted.
Owner
|
@StenAL Thank you for the changes! Even if its non-functional, i would still like to have a look at the changes (potential backdoors could easily be hidden in such changeset 😄), so it might take me a few days to approve this. If I do not respond until the end of the week, feel free to ping me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that the whole codebase looks consistent. I opted to use Palantir's formatting standard as it's already pretty close to the codebase's format and is widely used elsewhere.
I also added a
.git-blame-ignore-revsfile so the formatting changes do not show up ingit blame.No functional changes.