Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse the code section #66

Merged
merged 7 commits into from
Jan 28, 2025
Merged

Parse the code section #66

merged 7 commits into from
Jan 28, 2025

Conversation

virgil-serbanuta
Copy link
Member

@virgil-serbanuta virgil-serbanuta commented Jan 22, 2025 •
edited
Loading

Closes #61

@virgil-serbanuta virgil-serbanuta force-pushed the parse-functions-refactor branch from 1d75164 to fced21b Compare January 22, 2025 14:21
@virgil-serbanuta virgil-serbanuta changed the title Parse functions refactor Parse the code section Jan 22, 2025
@virgil-serbanuta virgil-serbanuta marked this pull request as ready for review January 22, 2025 16:15
sskeirik
sskeirik reviewed Jan 25, 2025
View reviewed changes
Copy link

@sskeirik sskeirik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, I've reviewed everything except the tests and instruction parser generator and all looks good. I left a couple minor comments.

I will finish that part of the next part of the review in a second round.

pykwasm/src/pykwasm/kdist/wasm-semantics/binary-parsing/int.md Outdated Show resolved Hide resolved
pykwasm/src/pykwasm/kdist/wasm-semantics/binary-parsing/func.md Outdated Show resolved Hide resolved
pykwasm/src/pykwasm/kdist/wasm-semantics/binary-parsing/int.md Show resolved Hide resolved
@virgil-serbanuta virgil-serbanuta force-pushed the parse-functions-refactor branch from 36c8623 to d9a126d Compare January 27, 2025 14:10
sskeirik
sskeirik approved these changes Jan 27, 2025
View reviewed changes
Copy link

@sskeirik sskeirik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!

@virgil-serbanuta virgil-serbanuta merged commit 0d78257 into master Jan 28, 2025
3 checks passed
@virgil-serbanuta virgil-serbanuta deleted the parse-functions-refactor branch January 28, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sskeirik sskeirik sskeirik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parse the code Section
2 participants
@virgil-serbanuta @sskeirik