Merged
Conversation
This will fix Netbeans inserting 2 tabs in the final generated project.
Contributor
Author
|
The project is completed for testing with module-info and without (making use of Will this PR be considered for merging? If not, I will not invest time in updating the docs. |
Collaborator
|
Good job |
Member
|
@Adito5393 thanks for your contribution!!! Regarding the documentation: this Maven Archetype is also described on https://pi4j.com/getting-started/developing-on-a-remote-pc/. Please, where applicable, update both the README in this repository and the website page on https://github.com/Pi4J/pi4j.github.io/blob/main/content/getting-started/developing-on-a-remote-pc.md. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on issue #1. Here is a working concept of how the archetype would handle the module-info.
TODO:
archetype-post-generate.groovyfile to delete themodule-info.javaif the user propertyuseJavaPlatformModuleSystem=false- the pom.xml does not need to be changed;useJavaPlatformModuleSystem,run.with.java.moduleandtarget.run.module.class) work;The current PR is a working JPMS project, so feel free to test it and provide feedback!