Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add java-last-kiosk for repeating previous java-kiosk invocation #14

Merged
merged 1 commit into from
Aug 12, 2021

Conversation

ppmathis
Copy link
Member

@ppmathis ppmathis commented Aug 9, 2021

This PR adds a new binary java-last-kiosk which will lookup the previous invocation of java-kiosk and repeats it. To do so, java-kiosk has been extended to store the current working directory and arguments in ~/.java-last-kiosk. As the script invokes java-kiosk again and does not store the Java invocation itself, it is also guaranteed that this command will work after a reboot when e.g. the DRI card device has changed.

The java-last-kiosk command supports two additional parameters, -n which will only print the command to manually re-run java-kiosk without executing it and -d which will enable debug-logging both for itself and java-kiosk.

Tracked as #6

Copy link
Contributor

@DieterHolz DieterHolz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me.

I tried to download the new image, but that didn't work. The download starts, but then you wait forever. Is that a temporary problem or is it just not possible to download these "unofficial images"?

@ppmathis
Copy link
Member Author

@DieterHolz This must have been a temporary issue, I downloaded the image yesterday successfully myself and just tried it once more and it worked on my side. Here also a direct link in case that might help?

@DieterHolz
Copy link
Contributor

Finally I could test the new image and the new last-kiosk command.

Works great!

@DieterHolz DieterHolz merged commit 59c279b into main Aug 12, 2021
@DieterHolz DieterHolz deleted the feat/last-kiosk branch August 12, 2021 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants