feat: add macOS system tray (menu bar) support - #7
Open
anlvdt wants to merge 1 commit into
Open
Conversation
Extend the existing Windows-only tray icon support to macOS, enabling the 'Send to Tray' workflow on macOS systems. Changes: - Add tray-icon, winit, and image dependencies for macOS target - Widen cfg gates from #[cfg(windows)] to #[cfg(any(windows, target_os = "macos"))] for tray module, SendToTray action, and auto-start usage window helpers - Keep Windows-specific console show/hide functions gated to Windows only - Add macOS icon candidate paths (Codex.app bundle locations) - All 91 existing tests pass with no warnings
Owner
|
Thanks for the PR, I assume this is superseded by #8 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the existing Windows-only tray icon support to macOS, enabling the Send to Tray workflow on macOS systems. Users can now switch Codex accounts directly from the macOS menu bar.
Changes
tray-icon,winit, andimagedependencies fortarget_os = "macos"inCargo.tomlcfggates from#[cfg(windows)]to#[cfg(any(windows, target_os = "macos"))]for:traymodule (lib.rs)SendToTrayaction and exit variant (app.rs,app/tui.rs)cli.rs)app/auto_start.rs)FreeConsole/AllocConsolefunctions gated to Windows onlyTesting
cargo build --release— clean build, zero warningscargo test— all 91 tests passMotivation
The tray icon is a very useful feature for account switching — currently only available on Windows. This PR brings the same experience to macOS users.