Skip to content

♻️refactor : 핀포인트 변수명 수정 #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
doup2001 merged 1 commit into from
Dec 28, 2025
Merged

♻️refactor : 핀포인트 변수명 수정 #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ain/java/com/pinHouse/server/platform/pinPoint/application/dto/UpdatePinPointRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@ public record UpdatePinPointRequest(
String name,

@Schema(description = "우선순위 설정 여부, true인 경우 최우선", example = "true")
Boolean isFirst
Boolean first
) {
}
8 changes: 4 additions & 4 deletions src/main/java/com/pinHouse/server/platform/pinPoint/application/service/PinPointService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ public void update(String id, UUID userId, UpdatePinPointRequest request) {
PinPoint pinPoint = loadPinPoint(id);

/// isFirst가 true로 변경되는 경우, 기존 first=true인 핀포인트를 false로 변경
if (request.isFirst() != null && request.isFirst() && !pinPoint.isFirst()) {
if (request.first() != null && request.first() && !pinPoint.isFirst()) {
Optional<PinPoint> existingFirstPinPoint = repository.findByUserIdAndIsFirst(userId.toString(), true);
existingFirstPinPoint.ifPresent(existingPinPoint -> {
existingPinPoint.setFirst(false);
Expand All @@ -96,9 +96,9 @@ public void update(String id, UUID userId, UpdatePinPointRequest request) {
/// 수정 (더티체킹)
pinPoint.updateName(request.name());

/// isFirst 값이 null이 아닌 경우에만 업데이트
if (request.isFirst() != null) {
pinPoint.setFirst(request.isFirst());
/// first 값이 null이 아닌 경우에만 업데이트
if (request.first() != null) {
pinPoint.setFirst(request.first());
}

repository.save(pinPoint);
Expand Down
Loading