Skip to content

Feat/api 버전 넘버링 적용 #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GoGradually merged 2 commits into from
Dec 31, 2025
Merged

Feat/api 버전 넘버링 적용 #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1eb8fe
feat: 로그인, 회원가입, 리프레시 경로 매칭 추가
GoGradually Dec 31, 2025
634dd58
docs: 새 API 버전 추가 시 주의사항 문서화
GoGradually Dec 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
### 새 API 버전 추가 시 주의할 점
- [ ] 새 API 버전에 대한 경로의 인증 필터링이 정상적으로 동작하나요?
- [ ] 프론트엔드에서 기존 API 버전도 정상적으로 동작하나요?
- [ ] 프론트엔드에서 새 API 버전을 사용하도록 변경되었나요?
4 changes: 4 additions & 0 deletions src/main/java/me/pinitgateway/security/SecurityConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,10 @@ private ServerWebExchangeMatcher authHostMatcher() {

private ServerWebExchangeMatcher authPathMatcher() {
return ServerWebExchangeMatchers.pathMatchers(
"/*/login",
"/*/signup",
"/*/refresh",
"/*/login/**",
Comment on lines +120 to +123
Copy link

Copilot AI Dec 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

문제점:
/*/signup/** 및 /*/refresh/** 패턴이 누락되어 있습니다. 현재 /*/login/**은 추가되었지만 (라인 123), signup과 refresh에는 하위 경로 패턴이 없습니다.

영향:

  • /v1/signup/confirm이나 /v2/refresh/token 같은 하위 경로가 있는 경우, 버전이 붙은 경로에 대해 인증 필터가 적용될 수 있습니다.
  • 기존 /login/** 패턴의 버전별 대응인 /*/login/**를 추가한 것처럼, /signup/** 및 /refresh/**에도 버전별 대응이 필요합니다.

수정 제안:
라인 121과 122 다음에 /*/signup/** 및 /*/refresh/** 패턴을 추가하여 일관성을 유지하세요.

Copilot generated this review using guidance from repository custom instructions.
"/login",
"/signup",
"/refresh",
Expand Down