Refactor the color picker slider #1896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s focus This was already used in ToolbarComboBox, and can be shared with the color picker slider to eliminate some hacky code
This allows us to start moving more of the logic to be encapsulated within the widget
This is based on the enum for the slider's color component, so the logic for updating it based on the slider should live there too (same for the gradient functions). This means that the slider widget can just provide a public property for setting the overall color and listening for color changes. Also removed the settings struct, which became small and can be replaced by regular parameters to the constructor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is some prep work for #1791 to make the ColorPickerSlider more encapsulated, so we can change its implementation to fix some of its interaction issues