Made alias repository case insensitive. Fixes #2087

PiranhaCMS · Jan 3, 2025 · 30b96e2 · 30b96e2
1 parent 8aa4c29
commit 30b96e2
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 3 deletions.
diff --git a/core/Piranha/Services/Internal/AliasService.cs b/core/Piranha/Services/Internal/AliasService.cs
@@ -108,7 +108,7 @@ public async Task<Alias> GetByAliasUrlAsync(string url, Guid? siteId = null)
 
             if (aliasUrls != null)
             {
-                var aliasUrl = aliasUrls.FirstOrDefault(x => x.AliasUrl == url);
+                var aliasUrl = aliasUrls.FirstOrDefault(x => x.AliasUrl.Equals(url, StringComparison.InvariantCultureIgnoreCase));
 
                 if (aliasUrl != null)
                 {

diff --git a/data/Piranha.Data.EF/Repositories/AliasRepository.cs b/data/Piranha.Data.EF/Repositories/AliasRepository.cs
@@ -85,7 +85,7 @@ public Task<Alias> GetByAliasUrl(string url, Guid siteId)
     {
         return _db.Aliases
             .AsNoTracking()
-            .Where(a => a.SiteId == siteId && a.AliasUrl == url)
+            .Where(a => a.SiteId == siteId && a.AliasUrl.ToLower() == url.ToLower())
             .Select(a => new Alias
             {
                 Id = a.Id,
@@ -109,7 +109,7 @@ public async Task<IEnumerable<Alias>> GetByRedirectUrl(string url, Guid siteId)
     {
         return await _db.Aliases
             .AsNoTracking()
-            .Where(a => a.SiteId == siteId && a.RedirectUrl == url)
+            .Where(a => a.SiteId == siteId && a.RedirectUrl.ToLower() == url.ToLower())
             .Select(a => new Alias
             {
                 Id = a.Id,

diff --git a/test/Piranha.Tests/Services/AliasTests.cs b/test/Piranha.Tests/Services/AliasTests.cs
@@ -210,6 +210,18 @@ public async Task GetByAliasUrl()
         }
     }
 
+    [Fact]
+    public async Task GetByAliasUrlWithDifferentCase()
+    {
+        using (var api = CreateApi())
+        {
+            var model = await api.Aliases.GetByAliasUrlAsync("/Old-URL");
+
+            Assert.NotNull(model);
+            Assert.Equal(ALIAS_1, model.AliasUrl);
+        }
+    }
+
     [Fact]
     public async Task GetByRedirectUrl()
     {
@@ -222,6 +234,18 @@ public async Task GetByRedirectUrl()
         }
     }
 
+    [Fact]
+    public async Task GetByRedirectUrlWithDifferentCase()
+    {
+        using (var api = CreateApi())
+        {
+            var models = await api.Aliases.GetByRedirectUrlAsync("/ReDiRect-1");
+
+            Assert.Single(models);
+            Assert.Equal(ALIAS_1, models.First().AliasUrl);
+        }
+    }
+
     [Fact]
     public async Task Update()
     {