Fail closed when gizmoduck viewer-age lookup errors - #42
Closed
Pitchfork-and-Torch wants to merge 19 commits into
Closed
Fail closed when gizmoduck viewer-age lookup errors#42Pitchfork-and-Torch wants to merge 19 commits into
Pitchfork-and-Torch wants to merge 19 commits into
Conversation
in_network_ids is passed to the VF client without deduplication, while oon_ids is deduped four lines below. retweeted_tweet_id is pushed for every candidate that has one, so the same ID repeats once per retweet of a given post — most often when that post is going viral. Neither VfClient implementation dedupes its input: StratoVfClient builds one call per element, and XaiVfClient chunks by XAI_VF_MAX_BATCH_SIZE, so duplicates consume batch slots and can force an extra round trip. Not a correctness issue — results collapse into a HashMap keyed by tweet ID — but redundant work on the For You serving path. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Deduplicate in_network_ids before VF lookup
Gizmoduck viewer RPC Err/timeout was mapped to ViewerAge::Unknown. SensitiveViewerUnderageDropRule and NoStatedAgeDropRule both miss Unknown, so NSFW/gore/card-image served as a normal card during an outage. Stamp LookupFailed and hard-drop sensitive media globally. Confirmed Unknown (no such user) and NotStated stay unchanged. Co-authored-by: Jon Bailey <Pitchfork-and-Torch@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Gizmoduck viewer RPC
Err/ timeout was collapsed toViewerAge::Unknown.SensitiveViewerUnderageDropRuleonly matchesKnown(age) < 18.SensitiveViewerNoStatedAgeDropRuleonly matchesNotStatedin a gating country.UnknownAllows.xai-org#133 left this: "RPC error already fails open as Unknown." Age-0 is now
NotStated. A failed read of a real logged-in viewer is not "no such user."This is not xai-org#133 (age 0 sentinel). This is not xai-org#125 (mixer origin NSFW). This is not xai-org#149 (VF author Failed → omit). This is not xai-org#144 (user-label miss).
Five-line proof
ViewerHydrator::hydrate(Err/ timeout used to stampUnknown)SensitiveViewerUnderageDropRule(LookupFailednow hard-drops sensitive media)Unknown(no such user) andNotStated(jurisdiction-scoped) are unchanged. Fail closed when VF gizmoduck author lookup is Err or missing xai-org/x-algorithm#149 owns author Failed.Change
Stamp
ViewerAge::LookupFailedon gizmoduck viewerErr/ timeout. The underage drop also fires onage_lookup_failedso sensitive media hard-drops globally, including outsideNSFW_GATING_COUNTRIES. Non-sensitive posts still serve.Tests
LookupFailed(notUnknown, not underage, notNotStated)LookupFaileddrops every sensitive firing candidate, including NSFW_TEXT in USLookupFailedallows a clean non-sensitive postUnknownstill Allows (confirmed no-such-user)gizmoduck_age_lookup_failed_drops_sensitive_mediaStandalone decision-table harness (same match arms): 15/15 passed.
cargo testcannot run. Public dump has no visibility-filtering crate manifest.Leftover
Author gizmoduck Failed is xai-org#149. Interstitial on an ancillary quote/RT is xai-org#143/xai-org#146. Account-country geo is xai-org#113.
Fork PR: none