Stop OON NSFW filter from skipping Phoenix retrieval - #67
Closed
Pitchfork-and-Torch wants to merge 19 commits into
Closed
Stop OON NSFW filter from skipping Phoenix retrieval#67Pitchfork-and-Torch wants to merge 19 commits into
Pitchfork-and-Torch wants to merge 19 commits into
Conversation
in_network_ids is passed to the VF client without deduplication, while oon_ids is deduped four lines below. retweeted_tweet_id is pushed for every candidate that has one, so the same ID repeats once per retweet of a given post — most often when that post is going viral. Neither VfClient implementation dedupes its input: StratoVfClient builds one call per element, and XaiVfClient chunks by XAI_VF_MAX_BATCH_SIZE, so duplicates consume batch slots and can force an extra round trip. Not a correctness issue — results collapse into a HashMap keyed by tweet ID — but redundant work on the For You serving path. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Deduplicate in_network_ids before VF lookup
The pre-scoring NSFW-author drop only matched ForYouSimclusters and only enabled when Simclusters was on. Phoenix, Phoenix MoE, TweetMixer, and topic retrieval of NSFW-author posts still entered RankingScorer. Drop the same OON NSFW-author posts from those retrieval sources, and enable the filter when any of them is on. Co-authored-by: Jon Bailey <Pitchfork-and-Torch@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
OONNsfwSimclustersFilteris the pre-scoring NSFW-author drop on For You OON retrieval. It only matchedForYouSimclustersand only enabled whenEnableSimclustersSourcewas on.Phoenix retrieval (
ForYouPhoenixRetrieval, including topics), Phoenix MoE, and TweetMixer use the same gizmoducknsfw_authorbit and the samein_networkstamp. NSFW-author posts from those sources still reachedPhoenixScorer/RankingScorer/TopKScoreSelector.This is not xai-org#169 (rank-all index writes). This is not xai-org#125 (gizmoduck origin size/NSFW). This is not xai-org#173 (safemodel hard-NSFW labels). In-network Thunder NSFW is unchanged.
Five-line proof
OONNsfwSimclustersFilterafterGizmoduckCandidateHydratorinPhoenixCandidatePipeline[PhoenixScorer, RankingScorer, VMRanker], thenTopKScoreSelectorserved_type == ForYouSimclusters; Phoenix / MoE / TweetMixer NSFW authors rankedChange
ForYouPhoenixRetrieval,ForYouPhoenixRetrievalMoe, andForYouTweetMixeras well as Simclustersin_network_onlyTests
in_network_only; enable on topic request when other sources are offStandalone rustc model of old vs new drop: 3/3 passed.
cargo testcannot run. Public dump has no home-mixer crate manifest.Fork PR: none