Stop TimelineHome from serving DMCA and geo-restricted media - #69
Closed
Pitchfork-and-Torch wants to merge 19 commits into
Closed
Stop TimelineHome from serving DMCA and geo-restricted media#69Pitchfork-and-Torch wants to merge 19 commits into
Pitchfork-and-Torch wants to merge 19 commits into
Conversation
in_network_ids is passed to the VF client without deduplication, while oon_ids is deduped four lines below. retweeted_tweet_id is pushed for every candidate that has one, so the same ID repeats once per retweet of a given post — most often when that post is going viral. Neither VfClient implementation dedupes its input: StratoVfClient builds one call per element, and XaiVfClient chunks by XAI_VF_MAX_BATCH_SIZE, so duplicates consume batch slots and can force an extra round trip. Not a correctness issue — results collapse into a HashMap keyed by tweet ID — but redundant work on the For You serving path. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Deduplicate in_network_ids before VF lookup
TES media legal/geo rules lived only on TimelineHomeRecommendations. Post-level legal takedown already drops on TimelineHome. Followee cards with DMCA media or a matching geo list therefore served on Following and For You in-network. Co-authored-by: Jon Bailey <Pitchfork-and-Torch@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
DropLegalTakendownPostRuleandDropLocalLawsTakendownPostRulesit inTES_HOME_DROPSand fire on both TimelineHome and TimelineHomeRecommendations.DropTweetsWithDmcaMediaRuleandDropTweetsWithGeoRestrictedMediaRulesat only inTIMELINE_HOME_RECOMMENDATION_ONLY_RULES.TES can mark media
has_dmca_mediaor attach a geo allow/deny list without a post-levelTakedownReason. Those followee posts scored at TimelineHome (Following, and For You in-network) and served.Five-line proof
has_dmca_mediaand mediageo_allow_list/geo_deny_list.TES_HOME_DROPS(shared).RECS_MEDIA_DROPSwas recommendation-only, so TimelineHome never evaluated those rows.VFCandidateHydratorscores followee / Following ids at TimelineHome.Twin:
TakedownReason::Dmcadrops on TimelineHome; media-level DMCA / geo does not. This is not xai-org#113 (account vs request country) and not xai-org#110 (labelapplicable_countries).Fix
Wire
RECS_MEDIA_DROPSintoTIMELINE_HOME_SHARED_RULESafterTES_HOME_DROPS(drops still precede interstitials). NSFW / DNA / spam recommendation-only rows stay OON-only.Tests (must fail on unmodified main)
legal_media_drops_on_timeline_home(fails on unmodified main)dmca_media_drops_in_networkcorpus case (wasdmca_media_allows_in_network)geo_denied_media_drops_in_networkcorpus casewired_rule_order_matches_pre_migration_sequencenow lists the two media rules on TimelineHomecargo: cannot run. Public dump has no visibility-filtering manifest.
Rejection table (this wave)