🎨 Palette: Standardize Accessibility for Instrument Controls#84
🎨 Palette: Standardize Accessibility for Instrument Controls#84Pitrat-wav wants to merge 1 commit intomainfrom
Conversation
- Enhanced `Knob.tsx` with `role="slider"`, keyboard support (Arrows, PageUp/Down, Home/End), and dynamic precision.
- Standardized drum pad accessibility in `DrumsScreen.tsx` with `role="button"`, `tabIndex={0}`, and keyboard support.
- Standardized sequencer step buttons in `DrumsScreen.tsx` and `BassScreen.tsx` with `role="switch"`, `tabIndex={0}`, and keyboard support.
- Properly associated labels with inputs and selects in instrument screens.
- Documented learnings in `.Jules/palette.md`.
Co-authored-by: Pitrat-wav <255843145+Pitrat-wav@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR standardizes accessibility across the main instrument controls. Non-native interactive elements (drum pads, sequencer buttons, and rotary knobs) have been updated with appropriate ARIA roles, labels, and full keyboard navigation support (tabIndex + onKeyDown handlers). Additionally, form-like elements (number inputs and selects) now have proper label-id associations for better screen reader compatibility.
PR created automatically by Jules for task 1480090271381242752 started by @Pitrat-wav