🎨 Palette: Studio HUD Accessibility & Precision Improvements#87
🎨 Palette: Studio HUD Accessibility & Precision Improvements#87Pitrat-wav wants to merge 1 commit intomainfrom
Conversation
This commit introduces several micro-UX and accessibility improvements to the 2D Studio HUD: 1. **Sequencer Accessibility**: Added `role="switch"`, `aria-checked`, and `aria-label` to sequencer step buttons in `DrumsScreen.tsx` and `BassScreen.tsx`, following the project's established accessibility patterns. 2. **Keyboard Visibility**: Implemented `:focus-within` neon glow effects on `StudioKnob` and `StudioSlider` wrappers in `StudioScreen.css`. Since the underlying native input is hidden, this provides essential visual feedback for keyboard users. 3. **Control Precision**: Enhanced `StudioKnob` and `StudioSlider` in `StudioScreen.tsx` to accept an optional `step` prop, allowing for finer parameter adjustments where needed. 4. **Documentation**: Updated `.Jules/palette.md` with learnings regarding keyboard accessibility for custom hardware-style controls. Verified via linting, unit tests, and code inspection. Co-authored-by: Pitrat-wav <255843145+Pitrat-wav@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Implemented accessibility improvements for sequencer buttons (role="switch", aria-checked) and added :focus-within styles for Studio knobs/sliders to support keyboard navigation. Also added a
stepprop to these controls for better precision.PR created automatically by Jules for task 14079137535970716813 started by @Pitrat-wav