Repository navigation
fix(library): restore the iOS header scroll background - #31
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
Library disabled the native top scroll-edge effect because it has no channel banner. Enable the iOS reading edge whenever there is no banner, so scrolled cards no longer show through the title. Banner feeds retain their existing behavior. Mac retains its separate toolbar-clipping behavior.
Targets main independently; no dependency on the player fix.
Verification
swift test: 22 tests passed on the base; these are visual-only changes../scripts/build.sh ios: passed on this branch. Baseline iOS and Mac ad-hoc builds passed.git diff --check: passed.01960bdand this branch in turn, opened Library, and scrolled the same first feed. Before, cards show behind the title; after, the native header background separates them. Captures cropped identically to the app window.Before / after evidence
Model: GPT-6.1 Sol | Harness: Codex in T3 Code