Repository navigation
fix(release): allow unattended Mac installer signing - #36
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
The Mac job in Preview release #3 stalled during installer export before the upload started. CI imported the signing keys with access for
codesignandsecurityonly;productbuildthen waited for an interactive Keychain password/approval on a headless runner.Authorize Apple's
/usr/bin/productbuildand/usr/bin/productsignalongside the existing signing tools when importing the temporary P12. Keep the existing temporary keychain, partition settings, and cleanup. Targets main independently, following merged #35.Verification
productbuildkey-access prompt. Stopped only that test's process group.scripts/testflight.sh export macoscompleted successfully without approval. Used the same certificate/P12, archive, profile, and API credentials; no compilation or new Apple upload.git diff --checkpassed. No unit test mirrors the tool allowlist; verification exercises the actual macOS key-access behavior.Before / after evidence
No app UI change. The real Keychain prompt reproduced the failure; the second export completed unattended. No credentials or temporary keychain passwords are included here.
Model: GPT-6.1 Sol | Harness: Codex in T3 Code