-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for building for Windows ARM64 devices #3430
base: dev
Are you sure you want to change the base?
Add support for building for Windows ARM64 devices #3430
Conversation
Filed as internal issue #USD-10450 ❗ Please make sure that a signed CLA has been submitted! |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
CLA sorted - approved by Tim Palmer |
Any reason why the testWrapper.py change you mentioned isn't included here? Otherwise, lgtm |
I figured it was more related to the version of python I have installed ( |
@@ -393,7 +393,10 @@ def RunCMake(context, force, extraArgs = None): | |||
|
|||
# Note - don't want to add -A (architecture flag) if generator is, ie, Ninja | |||
if IsVisualStudio2019OrGreater() and "Visual Studio" in generator: | |||
generator = generator + " -A x64" | |||
if "ARM" in os.environ.get('PROCESSOR_IDENTIFIER'): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could the platform
module be used here?
https://docs.python.org/3/library/platform.html#module-platform
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(repost from correct account)
It could be, but problems arise when running an emulated x64 version of python (which is easy to do by mistake, as that's what the website gives you by default).
This way checks the name of the processor directly, which is not affected by emulation.
"Python is currently switched off due to lack of support for PySide on these devices. I am looking at that seperately." Hi @anthony-linaro , per our call yesterday, you also mentioned that the python bindings are failing to compile -- can you post the error messages you are seeing there? "I also had to disable imaging, as building boost appears to be broken... " @sunyab , is it expected that the command line
would attempt to build boost in v24.11+ ? Thanks all! |
Description of Change(s)
Add support for Windows ARM64 devices.
This was tested using the following command line:
Python is currently switched off due to lack of support for PySide on these devices. I am looking at that seperately.
I also had to disable imaging, as building boost appears to be broken when using newer CMake versions (similar issue to #3285)
TBB is set to OneTBB, as 2020u3 doesn't support these devices.
I also had to make a small modification in
testWrapper.py
, and change line 134 topathPattern = pathPattern + r'(\S*)'
, as otherwise the escape sequence was invalid.Checklist
[x] I have created this PR based on the dev branch
[x] I have followed the coding conventions
[ ] I have added unit tests that exercise this functionality (Reference:testing guidelines)
[x] I have verified that all unit tests pass with the proposed changes
[x] I have submitted a signed Contributor License Agreement (Reference:
Contributor License Agreement instructions)