usdValidation: usdShade: ShaderValidator #3447
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added equivalent validation checks from ARShaderChecker in the new ValidationFramework, including validation implementation code, test code, tokens, and an entry in plugInfo.json
|
Filed as internal issue #USD-10490 |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tallytalwar
reviewed
Dec 10, 2024
There was a problem hiding this comment.
Hmm apologies @beersandrew but I think this also seems to be in the domain of validators which shouldn't be part of openUSD. There is nothing stopping a usdz package to have shaders with shaderId outside what has been mentioned here.
Also a shader having multiple connections is also a total valid usd (within a usdz package also) as per the UsdShade specifications.
The logic seems to be specific to SceneKit I think (cc. @dgovil) and is not what a usdzPackage will not allow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Link to proposal (if applicable)
Fixes Issue(s)
Note: This PR is a replacement for #3398
Checklist
[X] I have created this PR based on the dev branch
[X] I have followed the coding conventions
[X] I have added unit tests that exercise this functionality (Reference:
testing guidelines)
[X] I have verified that all unit tests pass with the proposed changes
[X] I have submitted a signed Contributor License Agreement (Reference:
Contributor License Agreement instructions)