Fix shader compile with metal in case decimal separator is comma #3467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cale is comma. GLSL version string was converted to floating point using sscanf. But sscanf expects decimal separator to match with current locale while GLSL version string always uses period as decimal separator. This caused Storm to fail e.g. on german systems.
|
Filed as internal issue #USD-10515 ❗ Please make sure that a signed CLA has been submitted! (This is an automated message. See here for more information.) |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Thanks for finding this problem! I was thinking it would be way simpler and local independent to parse like this, there's no need to use floating point numbers at all, really. |
|
You're right. Independent parsing of major and minor is way simpler. Thanks for this advise! Just changed it. |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GLSL version string was converted to floating point using sscanf. But sscanf expects decimal separator to match with current locale, while GLSL version string always uses period as decimal separator. This caused Storm to fail e.g. on german systems.