Added replaceable to foliage and corrected spelling everywhere #2276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Due to the hitboxes, while this tag works, this is currently not a fully suitable solution. Either the hitbox needs to be resized or replaceable needs to be modified so right clicking on the hitbox replaces rather than placing adjacent to to. |
Auseawesome
changed the title
Author
|
I've marked this as ready for review as the changes in it correctly add the tag. The additional functionality for blocks with a replaceable tag can be achieved in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2267
The refactor of replaceable's spelling is necessary because it will facilitate easy adding of this property on things in the future and avoid confusion as to why this behaviour was not working. (See issue to see how it was described to add .replaceable however it was spelled as .replacable in code leading to confusion when I went to solve this issue)