-
Notifications
You must be signed in to change notification settings - Fork 187
Make hovering over an item highlight all other items of that type #2277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
IntegratedQuantum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not convinced that this is a good idea. I personally find it a bit weird in-game.
@ikabod-kee please try this.
|
It could use more contrast, but I actually really like this change. I could see this working better if maybe the moused-over slot was outlined or white rather than just a darker blue. |
|
So: give the moused-over slots a white highlight, while the others get the old blue highlight. |
|
this is straight up counterintuintive and u cant even justify it, when hovering over a itemslot one would only expect the itemslot they are hovering on to be highlighted, this would just create people asking if its a bug it also looks wierd like quantum said, we really need more justification thats pretty convincing on this |
|
|
Perhaps having it be under a toggle/hold thing when pressing Ctrl, Shift, or Alt would work |
Since it doesn't actually obstruct anything on the screen (it isn't clutter) I don't think that should be necessary; maybe we could have a toggle in settings for it? |
|
Yeah, a toggle in the settings sounds nice. I do actually like the feature. |
|
Also, it seems like some checks are failing. I'll check out the new changes when I can |
Yeah, I'll fix that in a bit. |
|
As an alternative to toggle, you could also make the highlight of other slots of same type less visible (can I get a screenshot? It should have been included in the description!) |


Fixes #2271
This will conflict with #2247, although it should be an easy fix.