Skip to content

Conversation

@codemob-dev
Copy link
Contributor

@codemob-dev codemob-dev commented Nov 13, 2025

Fixes #2271
This will conflict with #2247, although it should be an easy fix.

@codemob-dev codemob-dev moved this to Easy to Review in PRs to review Nov 13, 2025
@IntegratedQuantum IntegratedQuantum moved this from Easy to Review to Low Priority in PRs to review Nov 13, 2025
Copy link
Member

@IntegratedQuantum IntegratedQuantum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not convinced that this is a good idea. I personally find it a bit weird in-game.
@ikabod-kee please try this.

@IntegratedQuantum IntegratedQuantum moved this from Low Priority to In review in PRs to review Dec 1, 2025
@ikabod-kee
Copy link
Collaborator

It could use more contrast, but I actually really like this change.

I could see this working better if maybe the moused-over slot was outlined or white rather than just a darker blue.

@ikabod-kee
Copy link
Collaborator

So: give the moused-over slots a white highlight, while the others get the old blue highlight.

@ikabod-kee
Copy link
Collaborator

image Getting this error when running

@codemob-dev
Copy link
Contributor Author

image Getting this error when running

Fixed

@SpellDigger
Copy link

this is straight up counterintuintive and u cant even justify it, when hovering over a itemslot one would only expect the itemslot they are hovering on to be highlighted, this would just create people asking if its a bug

it also looks wierd like quantum said, we really need more justification thats pretty convincing on this

@codemob-dev
Copy link
Contributor Author

u cant even justify it

  1. It highlights items that you already have if you go to craft something
  2. It makes it easier to count how many of a specific item you have

@ikabod-kee
Copy link
Collaborator

Perhaps having it be under a toggle/hold thing when pressing Ctrl, Shift, or Alt would work

@codemob-dev
Copy link
Contributor Author

Perhaps having it be under a toggle/hold thing when pressing Ctrl, Shift, or Alt would work

Since it doesn't actually obstruct anything on the screen (it isn't clutter) I don't think that should be necessary; maybe we could have a toggle in settings for it?

@ikabod-kee
Copy link
Collaborator

Yeah, a toggle in the settings sounds nice. I do actually like the feature.

@ikabod-kee
Copy link
Collaborator

Also, it seems like some checks are failing. I'll check out the new changes when I can

@codemob-dev
Copy link
Contributor Author

Also, it seems like some checks are failing. I'll check out the new changes when I can

Yeah, I'll fix that in a bit.

@Argmaster
Copy link
Collaborator

As an alternative to toggle, you could also make the highlight of other slots of same type less visible (can I get a screenshot? It should have been included in the description!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

Hovering over an item should highlight all items of that type

5 participants