Skip to content

1 line readability fix in renderer #2316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vinywar123 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

1 line readability fix in renderer #2316

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/renderer.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1010,6 +1010,7 @@ pub const MeshSelection = struct { // MARK: MeshSelection
const neighborBlock = block;
oldBlock = mesh_storage.getBlockFromRenderThread(neighborPos[0], neighborPos[1], neighborPos[2]) orelse return;
block = oldBlock;
// Check if the neighbor block has a block and that it is the same type as the placed item
Copy link
Member

@IntegratedQuantum IntegratedQuantum Nov 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first part "Check if the neighbor block has a block" makes no sense, what does it mean for a block to have a block???
And the second part "that it is the same type as the placed item" is just describing the code, and in my opinion is not more or less readable than block.typ == itemBlock. If you think this part is unclear then a better choice would be to use a more descriptive variable name instead of a comment.

So overall in my opinion this comment, in its current state, makes the code more confusing than before.

if(block.typ == itemBlock) {
if(rotationMode.generateData(main.game.world.?, neighborPos, relPos, lastDir, neighborDir, neighborOfSelection, &block, neighborBlock, false)) {
if(!canPlaceBlock(neighborPos, block)) return;
Expand Down