-
Notifications
You must be signed in to change notification settings - Fork 187
Phantasmal #2359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phantasmal #2359
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file names (this applies to most of them), are quite redundant pillar/top/pillar_top_x or pillar/small/small_pillar_x
Please remove all the redundancy pillar/top/x pillar/small/x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here, should probably be auroras/high/x, not auroras/aurorahigh/x
assets/cubyz/biomes/cave/void/rare/phantasmal/starlight.zig.zon
Outdated
Show resolved
Hide resolved
IntegratedQuantum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few more small things, then I'd be ready to merge
|
oh and also fix the CI failure please |
IntegratedQuantum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright this is it. Thank you for your patience.
At the beginning I was a bit skeptical, but I think it turned out great, so thank you for this.
A series of biomes, primarily found in the caves, along with one on the surface. They have strange alien pillars along with glowing formations in the sky. The variants are the archipelago, starlight, streamer, and cave variants. Pictures of each below.
The archipelago is formed in oceans, just below the waves.


The cave variant has no floating glowy formations and only generates in caves.


The starlight and streamer variants are in the roots, and have two different glowing formations above them.



