Skip to content

Conversation

@tillpp
Copy link
Contributor

@tillpp tillpp commented Dec 13, 2025

If someone else breaks the block you already broke, the animations just stays there in there in the Air.
(Like in this picture)

grafik

This PR does only partly solves: #1048
There is still the problem that if you chisel and someone else breaks the block, you still see your animation in the air.

Thanks for Mischol (@thcae) for Play testing.

@Argmaster Argmaster moved this to Easy to Review in PRs to review Dec 14, 2025
pub fn stopBreakBlock(pos: Vec3i) void {
if(@reduce(.And, lastSelectedBlockPos == pos)) {
mesh_storage.removeBreakingAnimation(lastSelectedBlockPos);
currentBlockProgress = 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look for a solution that keeps the breaking progress of the block when you release the button.

Also note that in the future we would want to support multiple block breaking animations from multiple players, synchronized through the server.

@IntegratedQuantum IntegratedQuantum moved this from Easy to Review to In review in PRs to review Dec 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

2 participants