Set Spawn command (continuation of #2374) #2447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
thanks for picking this up |
Closed
IntegratedQuantum
requested changes
Jan 11, 2026
Co-authored-by: IntegratedQuantum <[email protected]>
IntegratedQuantum
requested changes
Jan 12, 2026
src/server/command/spawn.zig
Outdated
| return; | ||
| } | ||
| } | ||
| if(x == null or y == null) { |
Member
There was a problem hiding this comment.
Should only trigger when x is null, and needs a separate case for x != null and y == null
Contributor
Author
There was a problem hiding this comment.
should be done, but cannot test because of #2485
Member
There was a problem hiding this comment.
try it in a new world
Contributor
Author
There was a problem hiding this comment.
with different world it worked. But I don't like the wording of the message (I changed it since my comment) maybe just send the usage?
Member
There was a problem hiding this comment.
Yeah, sending the usage would be good.
Also note that with #1425 we would also get more consistent error messages.
Contributor
Author
There was a problem hiding this comment.
now its sending the usage
IntegratedQuantum
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to the PR #2374 from @Vinywar123 :