-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings: add FPS cap #532
Conversation
Actually, I would group point 4 along with #438. |
Sliders are bugged for me in general. We might want to round the fps from the slider because people probably usually just want to reset it to 60 fps without a hassle. On the other hand, some people prefer to set their framerate just under the refresh rate for some reason, so I'm not sure which is a priority. |
You could also make it a text field. Then players could be arbitrarily precise. |
It crashes when I move the slider to the end:
I'm guess this happens because you return a global string from your format function, which gets freed later. |
Does it crash in release mode for you? |
It not crash in ReleaseFast, but it does crash in ReleaseSafe. |
Zig no longer reports memory issues, but I don't think I accomplished that in the cleanest way. |
Could you also fix the merge conflicts? |
Fixed. |
Adds
fpsCap
field which lets Cubyz sleep if it processes the frame fast enough. On lower end hardware, this would let Cubyz deliver a more consistent framerate, albeit lower.update fps label in debug window to count actual frames, not inverse rendering timeResolves #487.