-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some updates #40
base: master
Are you sure you want to change the base?
Some updates #40
Conversation
e965
commented
Mar 13, 2019
•
edited
Loading
edited
- Changed the link for js-yaml lib (because RawGit will close soon)
- "build" task is fixed (some file paths were wrong)
- XMLHttpRequest is replaced by fetch
Because [RawGit](https://rawgit.com) will close soon.
"build" task is fixed, XMLHttpRequest is replaced by fetch
Okay, so I wanna clarify that both fetch wasn't used and yaml is imported like that for the same reason, back when I made this, satania.moe wasn't running on webpack (actually, I don't think webpack was even popular back then) so I did not use fetch to ensure we were compatible with IE (which is still used a lot by our Chinese visitors) and imported YAML from an URL because I had no other ways to manage dependencies back then lol. Now it would be better to put YAML as a dependency and add a fetch pollyfill. Also I'm not sure about what you're doing with gulp-rename there? |
Fix previous fix (with build paths issue), added fetch and js-yaml polyfills
In the current version of the project, the build paths of some files are broken (e.g. |
(forget the last message I didn't get what you meant) No this is the intended file structure. As with most Gulp projects, things in src/ go into dist/, I put assets at the root just because there is no reason not to do that in the built website |
No wait it does look like it (I am really terrible today oh my god) |
My working dir is the one into which I have cloned the git repository. |
I have found the problem, it's the use of Normally, Gulp can find the "parent" of a Glob, so for instance, in But the Globs are generated with Solution: This will be fixed in an upcoming commit |
As mentionned on Pizzacus#40