Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] develop from decidim:develop #165

Merged
merged 55 commits into from
Aug 25, 2023
Merged

Commits on Aug 1, 2023

  1. Redesign: counteract the hover effects of the dropdown (#11253)

    * hack to counteract the hover effects of the dropdown
    
    * keep menu unreachable onload
    
    * due to a bug in Chrome, move the inline events to script tags
    
    more info: https://bugs.chromium.org/p/chromium/issues/detail?id=868224&q=ontransitionend&colspe[%E2%80%A6]Block%20Component%20Status%20Owner%20Summary%20OS%20Modified
    
    * fix spelling
    
    * extract script to separate file
    
    * restore removed element
    
    * fix spelling
    
    * trigger manually dropdown controller on hover parent
    
    * move onmouseenter only to link
    
    * handle dropdowns only via css animation
    
    * no longer required
    
    * fix styles
    
    * disable animations on page load
    
    * fix tests
    
    * fix syntax
    Crashillo authored Aug 1, 2023
    Configuration menu
    Copy the full SHA
    fa30cdf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    83c8d75 View commit details
    Browse the repository at this point in the history
  3. Tiny typo fix (#11428)

    RCheesley authored Aug 1, 2023
    Configuration menu
    Copy the full SHA
    ca2b3f5 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. Redesign: rename tests (#11184)

    * Remove skip_unless_redesing_enabled calls in tests
    
    * Remove redesign_helpers for tests
    
    * Unskip and adapt REDESIGN_PENDING examples
    
    * Remove deprecated examples
    
    * Allow to configure the default header level of attributes titles in diff cell
    
    * Ensure accessibility of h in collaborative draft show
    
    * Recover accessibility tests in proposals
    
    * Remove comments
    
    * Unskip and adapt test
    
    * Fix expected text of link in test
    
    * Remove check for removed follow actions in participatory text index
    
    * Unskip tests
    
    * Unskip and adapt to vote proposal tests
    
    * Remove deprecated methods
    
    * Remove deprecations in tests
    
    * Remove collaborative drafts and proposals deprecated m cells
    
    * Adapt proposal m cell cache hash to l cell
    
    * Adapt proposal m-cell specs to l-cell
    
    * Replace use of proposal_m card
    
    * Remove condition on redesign from test
    
    * Rename shared examples for attachments to not use redesign term
    
    * Remove tests for CTA behavior deprecated in processes card-g
    
    * Avoid duplicated ids of highlighted participatory process in menu breadcrumb
    
    * Recover skipped examples
    
    * Recover accessibility tests in participatory processes
    
    * Remove participatory process description specs and include expected contents with metadata content block enabled
    
    * Unskip REDESIGN_PENDING tests
    
    * Move common statistics cells tests to shared examples
    
    * Remove unused process metadata item
    
    * Remove deprecated proceses m card and add tests for l and g cards
    
    * Remove deprecated process group m card cell
    
    * Recover tests after redesign in initiatives
    
    * Remove skipped deprecated tests
    
    * Remove assemblies description page test and move examples to show page with appropriate content blocks
    
    * Remove assembly m card and related tests
    
    * Unskip tests after completing redesing
    
    * Adapt sorting test to redesigned interface
    
    * Remove deprecated sorting tests because the redesigned interface prevents incomplete sortings
    
    * Unskip tests
    
    * Remove post m card cell
    
    * Remove reference to redesign from test
    
    * Remove comment m card
    
    * Unskip accessibility test in debates versions
    
    * Remove deprecated test
    
    * Remove deprecated comments about redesign
    
    * Remove deprecated test
    
    The proposals card-l does not show the supports count in the metadata,
    so there is no difference when supports are enabled on proposals
    component or not
    
    * Remove useless reference to redesign in test
    
    * Remove REDESIGN_PENDING comment: do not use card-l cell for media links
    
    * Remove REDESIGN_PENDING comments
    
    * Remove unused partial
    
    * Unskip tests
    
    * Remove conference m card cell
    
    * Adapt authorizations tests to redesign
    
    * Remove deprecated tests
    
    * Avoid errors in upload modal when file validation fails
    
    * Unskip tests
    
    * Remove deprecated test
    
    * Remove REDESIGN_PENDING comments
    
    * Update map styles in proposals
    
    * Uncomment tests
    
    * Uncomment and adapt selector in tests
    
    * Remove reference to redesign
    
    * Fix linter offense
    
    * Remove obsolete brakeman skip and update other in proposals
    
    * Remove unused translations and add some wizards keys to ignore unused
    
    * Update expected url in activity cell with comments activities
    
    * Increase header levels in version cell to include h1
    
    * Recover missing data attribute in hero content block
    
    * Fix coordinates update in add_proposal js
    
    * Hide map only if there is no address with coordinates
    
    * Empty address field before changing it in test
    
    * Add issue reference to skipped tests
    
    * Display replies on deleted comments and keep then with AJAX deletion refresh
    
    * Unskip test
    
    * Update decidim-core/app/cells/decidim/version/show.erb
    
    Co-authored-by: Alexandru Emil Lupu <[email protected]>
    
    * Use h2 tag
    
    * Move shared examples require to core
    
    * Replace actions with method doing the same
    
    * Fix test
    
    * Remove references to redesign in shared examples
    
    ---------
    
    Co-authored-by: Alexandru Emil Lupu <[email protected]>
    entantoencuanto and alecslupu authored Aug 2, 2023
    Configuration menu
    Copy the full SHA
    0c0a493 View commit details
    Browse the repository at this point in the history
  2. Redesign: refactor the scope of the main Javascript initializer (#11317)

    * set the scope of all functions that are initialized at startup
    
    * scope the datepicker as well
    
    * remove precated js stuff (testing)
    
    * fix lint & place accordingly the initializations
    Crashillo authored Aug 2, 2023
    Configuration menu
    Copy the full SHA
    633f22b View commit details
    Browse the repository at this point in the history
  3. Redesign: deprecate foundation-datepicker from public site (#11420)

    * deprecate foundation-datepicker public site
    
    * fix core tests
    
    * fix datepicker tests
    
    * fix lint and rubocop
    
    * replace now with current
    
    * fix tests
    
    * fix more tests
    
    * fix tests
    
    * remove byebugs
    Crashillo authored Aug 2, 2023
    Configuration menu
    Copy the full SHA
    3187bdf View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2023

  1. Configuration menu
    Copy the full SHA
    e4ce766 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bd7b3c0 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2023

  1. Two-columns layout fix (#11400)

    * Column conversations fix
    
    * suggested changes added to &__aside
    
    * &__main updated
    
    * Changes made to span on &__main
    
    * test
    
    * spacing cli test
    greenwoodt authored Aug 7, 2023
    Configuration menu
    Copy the full SHA
    035771c View commit details
    Browse the repository at this point in the history
  2. Disabler for pointer events (#11449)

    * Added a disabler for pointer event
    
    * Improved workaround for the tabs +1
    
    * Indentation line 19
    greenwoodt authored Aug 7, 2023
    Configuration menu
    Copy the full SHA
    00430f5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6e7111d View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2023

  1. Configuration menu
    Copy the full SHA
    177e03a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cdae401 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5c18079 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f86a57a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    21008a5 View commit details
    Browse the repository at this point in the history
  6. Force capital starting letter for PR titles (#11457)

    * Force capital starting letter for PR titles
    
    * Force the starting character to be capitalized
    ahukkanen authored Aug 8, 2023
    Configuration menu
    Copy the full SHA
    6e4a27d View commit details
    Browse the repository at this point in the history
  7. Allow disabling password expiration (#11135)

    * Allow disabling password expiration
    
    NIST does not recommend expiring passwords:
    https://pages.nist.gov/800-63-FAQ/#q-b05
    
    * Add documentation about the new option
    
    * Fix linter
    
    * Fix linter
    carlobeltrame authored Aug 8, 2023
    Configuration menu
    Copy the full SHA
    86900a5 View commit details
    Browse the repository at this point in the history
  8. Fix autocomplete result list duplicates (#11442)

    * Fix autocomplete user group duplication / Add system test
    
    * Fix test
    JoonasAapro authored Aug 8, 2023
    Configuration menu
    Copy the full SHA
    4298068 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. Redesign: organization colors (#11451)

    * refactor the organization colors
    
    * typo
    
    * remove specs about them_color input
    
    * fix specs
    
    * use old red for testing
    
    * set the default redesign colors to the organization factory (color-contrast)
    
    * replace the uses of legacy primary color
    Crashillo authored Aug 9, 2023
    Configuration menu
    Copy the full SHA
    52b3249 View commit details
    Browse the repository at this point in the history
  2. Redesign: axe accessibility issues (#11403)

    * dropdown card does not require an id
    
    * add aria-label to progress bar
    
    * disable dropdown for desktop navigation
    
    * Refactor the use of filter_text_for to be in views instead of helpers
    
    * Allow passing an id to filter_text_for method
    
    * remove element_id (testing)
    
    * pass the id to the label
    
    * distinguish filters and order controls
    
    * distinguish all uses of dropdown-menus
    
    * rename control
    
    * don't use a list when you need divs
    
    * disable dropdown for desktop navigation
    
    * update code for emoji
    
    * remove ids from tests
    
    * fix core tests
    
    * fix election tests
    
    * fix tests
    
    * remove profile__user-role class
    
    * remove needless aria-attribute
    
    * remove duplicated ids
    
    * empty merge
    
    * Include alternative title for images when there's nothing but the title
    
    * disable dropdown for desktop
    
    * add alt text to default image
    
    * user profile must not be an h5
    
    * duplicate_id and copy button SR text
    
    * fix odd layout for edit initiative
    
    * redesign committee requests form
    
    * fix a11y issue on budgets project list
    
    * mark layout item header al role=complementary since it's outside
    
    * do not expand elements if the page has very few contents
    
    * fix a11y issue on debates, sortitions and forms
    
    * fix rubocop
    
    * fix erblint
    
    * use the units as the aria-label
    
    * standarize arias for progress bars
    
    * initiatives style glitch
    
    ---------
    
    Co-authored-by: Eduardo Martinez Echevarria <[email protected]>
    Crashillo and entantoencuanto authored Aug 9, 2023
    Configuration menu
    Copy the full SHA
    dee0ad9 View commit details
    Browse the repository at this point in the history
  3. Integrate Bullet in decidim-dev (#11416)

    * Initial commit on bullet integration
    
    * remove uneeded condition
    
    * Disable failing actions
    
    * Disable failing workflows
    
    * Disable all the workflows
    
    * Refactor actions
    
    * Revert generator change
    alecslupu authored Aug 9, 2023
    Configuration menu
    Copy the full SHA
    fd44a1c View commit details
    Browse the repository at this point in the history
  4. Redesign: comment button (#11461)

    * render the comment button depending of the settings
    
    * enhance condition: initiatives is not a component
    
    * handle comments_blocked? in case of null
    
    * fix offenses
    Crashillo authored Aug 9, 2023
    Configuration menu
    Copy the full SHA
    45d7677 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a77a787 View commit details
    Browse the repository at this point in the history
  6. Redesign: remove the item itself from nav menu (#11452)

    * remove the item itself from nav menu
    
    * fix i18n
    
    * fix specs
    
    * fix specs
    Crashillo authored Aug 9, 2023
    Configuration menu
    Copy the full SHA
    8a5e5c2 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. Configuration menu
    Copy the full SHA
    4acbdba View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2023

  1. Configuration menu
    Copy the full SHA
    07b41df View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    aa7b546 View commit details
    Browse the repository at this point in the history
  3. Redesign: resource metadata (#11463)

    * make every resource metadata equal
    
    * remove any reference to "drawer"
    
    * typo
    
    * slightly different initiative layout
    Crashillo authored Aug 14, 2023
    Configuration menu
    Copy the full SHA
    65dbb33 View commit details
    Browse the repository at this point in the history
  4. Redesign: display alert when no projects (#11480)

    * display alert when no projects
    
    * normalize locals
    Crashillo authored Aug 14, 2023
    Configuration menu
    Copy the full SHA
    50a1f9f View commit details
    Browse the repository at this point in the history
  5. Redesign: system (#11478)

    * prepare assets and login page
    
    * responsive sidebar system
    
    * organization forms
    
    * refactor organization forms
    
    * password forms
    
    * admins forms
    
    * oauth forms
    
    * fix typo
    
    * fix specs and required update modal
    
    * fix lint
    
    * fix lint
    
    * update test settings
    
    * avoid aside to expand
    
    * remove deprecated styles
    Crashillo authored Aug 14, 2023
    Configuration menu
    Copy the full SHA
    bf8efbb View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. Configuration menu
    Copy the full SHA
    e8999d3 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2023

  1. Configuration menu
    Copy the full SHA
    612e4a1 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2023

  1. Redesign: consolidate 2-col layout (#11426)

    * spacing for participatory_processes, proposals, collaborative drafts, participatory texts and component announcement
    
    * spacing for sortitions, elections, meetings and fixes over proposals
    
    * spacing for assemblies and fixes over participatory spaces
    
    * fix tests
    
    * spacing for core
    
    * spacing for conferences, blogs and accountability. Fixes over conversations
    
    * aside heading responsive and spacig for budgets
    
    * spacing for projects, debates and initiatives
    
    * fix initiative specs
    
    * fix proposals specs
    
    * fix specs
    
    * missing space for collaborative drafts
    
    * avoid overwritting css rule du to tailwind directive
    
    * missing class
    
    * avoid weird space around the span
    
    * missing condition
    Crashillo authored Aug 20, 2023
    Configuration menu
    Copy the full SHA
    bc7fc7f View commit details
    Browse the repository at this point in the history
  2. Encode non-ASCII characters on external links (#11472)

    * Encode non-ASCII characters on external links
    
    * Lint
    
    * Apply suggestions
    fblupi authored Aug 20, 2023
    Configuration menu
    Copy the full SHA
    449694c View commit details
    Browse the repository at this point in the history
  3. Fix weird behavior with votes in comments (#11490)

    * Fix weird behavior with votes in comments
    
    * Fix flaky test
    fblupi authored Aug 20, 2023
    Configuration menu
    Copy the full SHA
    210869e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    79d46e5 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b465564 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    6de7e06 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. Incorrect component link generation (#11432)

    * Fix SEO routing issue for components index
    
    * Add tests for the redirects
    
    * Fix failing tests
    
    * Fix failing specs
    
    * Fix all failing tests
    
    * Fix linting error
    sinaeftekhar authored Aug 21, 2023
    Configuration menu
    Copy the full SHA
    e6cc73b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    44aa742 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b029e4f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    657306e View commit details
    Browse the repository at this point in the history
  5. Redesign: finish create-initiative step (#11493)

    * simplify the finish create-initiative step
    
    * restore original condition
    Crashillo authored Aug 21, 2023
    Configuration menu
    Copy the full SHA
    ce4cf6f View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. Configuration menu
    Copy the full SHA
    cd0af97 View commit details
    Browse the repository at this point in the history
  2. Fix wrong 'no activity' text on last activities page (#11496)

    * Fix wrong 'no activity' text on last activities page
    
    * Fix failing spec
    alecslupu authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    613be74 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. Redesign: meetings code icon (#11486)

    * replace qr code icon with another related
    
    * change icon
    Crashillo authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    9679640 View commit details
    Browse the repository at this point in the history
  2. Redesign: highlight links on hover (#11508)

    * hightlight links on hover
    
    * highlight footer links
    
    * distinguisable link banner
    
    * place "skip to content" the first thing of all
    Crashillo authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    0cf1aa8 View commit details
    Browse the repository at this point in the history
  3. Focus styles (#11509)

    Crashillo authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    f231119 View commit details
    Browse the repository at this point in the history
  4. Redesign: semantic datetimes (#11513)

    * include datetime semantically
    
    * calendar a11y
    
    * ignore missing translation
    Crashillo authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    f9c0e25 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    186d10f View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. Configuration menu
    Copy the full SHA
    6f6d64f View commit details
    Browse the repository at this point in the history
  2. Show different text for the Register CTA when the user is already reg…

    …istered (#11511)
    
    * Show different text for the Register CTA when the user is already registered
    
    * Change two more buttons
    
    * Normalize i18n
    fblupi authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    860418b View commit details
    Browse the repository at this point in the history
  3. Don't show initiative state field instead of showing it disabled (#11518

    )
    
    * Don't show initiative state field instead of showing it disabled
    
    * Don't show the field in the edit form neither
    
    * Add tests
    
    * Lint files
    
    * Update decidim-initiatives/app/views/decidim/initiatives/initiatives/_form.html.erb
    
    Co-authored-by: Alexandru Emil Lupu <[email protected]>
    
    ---------
    
    Co-authored-by: Alexandru Emil Lupu <[email protected]>
    fblupi and alecslupu authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    295c7a1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    37358ca View commit details
    Browse the repository at this point in the history