Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/questionnaire exports #28

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from
Open

Conversation

verarojman
Copy link

@verarojman verarojman commented Jul 13, 2020

🎩 What? Why?

This PR fixes some bugs related to exporting questionnaires and adds some other improvements:

  • Exports
    • Adds options hash for export_manifest to decide whether file should be zipped
    • Makes surveys exports not be zipped by default to improve UX
  • Form PDF
    • Render newlines for short_answer and long_answer answers
    • Render matrix answers correctly
    • Remove ip_hash to improve readability of participant information
  • Bugfixes
    • Remove bug happening when exporting answers to questions with position: nil

📌 Related issues

📋 Subtasks

  • Add tests
  • Add question_count to questionnaire to skip separators in count >> fix completion percentage calculation for questionnaires
  • Check why organization logo is not being rendered in pdf
  • Design for PDF footer 'made with Decidim'
  • Change export email message so it doesn't say "zipped"

@microstudi microstudi mentioned this pull request Jul 23, 2020
13 tasks
@microstudi
Copy link

@verarojman Important bug:
It seems that if you have more than one component with surveys, export results show all the results for all the components mixed.

@microstudi
Copy link

Completion seems capable of exceeding 100% using matrix questions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants