Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update local execute function #2

Merged
merged 9 commits into from
May 15, 2019
Merged

Update local execute function #2

merged 9 commits into from
May 15, 2019

Conversation

nima-ap-zz
Copy link
Contributor

The following PR updates the local implementation of execute function to address

  1. changes in function execution context and mainserver payload contracts to AFs
  2. changes to gzip compression strategy to fix a bug

It is based off of the original branch in which local execute function was added on yet never merged into master and hence contains a fresh file diff here.

@nima-ap-zz nima-ap-zz requested a review from MGudgin May 15, 2019 20:46
MGudgin
MGudgin suggested changes May 15, 2019
View reviewed changes
Copy link
Contributor

@MGudgin MGudgin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put this file in a 'csharp' subdirectory. Over time we'll add versions of this for other languages and I'd rather have them in their own directory, just in case we end up with multiple files for some languages.

MGudgin
MGudgin reviewed May 15, 2019
View reviewed changes
@nima-ap-zz nima-ap-zz merged commit 5d0a761 into master May 15, 2019
@nima-ap-zz nima-ap-zz deleted the nima/csharp-execute-function branch May 15, 2019 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGudgin MGudgin MGudgin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nima-ap-zz @MGudgin @nima-ap