Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump ws and puppeteer #1

Open
wants to merge 2 commits into
base: Current
Choose a base branch
from
Open

Bump ws and puppeteer #1

wants to merge 2 commits into from

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Jun 19, 2024 •
edited
Loading

Bumps ws to 8.17.1 and updates ancestor dependency puppeteer. These dependencies need to be updated together.

Updates ws from 8.5.0 to 8.17.1

Release notes

Sourced from ws's releases.

8.17.1

Bug fixes

  • Fixed a DoS vulnerability (#2231).

A request with a number of headers exceeding the[server.maxHeadersCount][] threshold could be used to crash a ws server.

const http = require('http');
const WebSocket = require('ws');
const wss = new WebSocket.Server({ port: 0 }, function () {
const chars = "!#$%&'*+-.0123456789abcdefghijklmnopqrstuvwxyz^_`|~".split('');
const headers = {};
let count = 0;
for (let i = 0; i < chars.length; i++) {
if (count === 2000) break;
for (let j = 0; j &lt; chars.length; j++) {
  const key = chars[i] + chars[j];
  headers[key] = 'x';
if (++count === 2000) break;
}

}
headers.Connection = 'Upgrade';
headers.Upgrade = 'websocket';
headers['Sec-WebSocket-Key'] = 'dGhlIHNhbXBsZSBub25jZQ==';
headers['Sec-WebSocket-Version'] = '13';
const request = http.request({
headers: headers,
host: '127.0.0.1',
port: wss.address().port
});
request.end();
});

The vulnerability was reported by Ryan LaPointe in websockets/ws#2230.

In vulnerable versions of ws, the issue can be mitigated in the following ways:

  1. Reduce the maximum allowed length of the request headers using the [--max-http-header-size=size][] and/or the [maxHeaderSize][] options so that no more headers than the server.maxHeadersCount limit can be sent.

... (truncated)

Commits
  • 3c56601 [dist] 8.17.1
  • e55e510 [security] Fix crash when the Upgrade header cannot be read (#2231)
  • 6a00029 [test] Increase code coverage
  • ddfe4a8 [perf] Reduce the amount of crypto.randomFillSync() calls
  • b73b118 [dist] 8.17.0
  • 29694a5 [test] Use the highWaterMark variable
  • 934c9d6 [ci] Test on node 22
  • 1817bac [ci] Do not test on node 21
  • 96c9b3d [major] Flip the default value of allowSynchronousEvents (#2221)
  • e5f32c7 [fix] Emit at most one event per event loop iteration (#2218)
  • Additional commits viewable in compare view

Updates puppeteer from 13.7.0 to 22.11.2

Release notes

Sourced from puppeteer's releases.

puppeteer-core: v22.11.2

22.11.2 (2024-06-18)

Bug Fixes

puppeteer: v22.11.2

22.11.2 (2024-06-18)

Miscellaneous Chores

  • puppeteer: Synchronize puppeteer versions

Dependencies

  • The following workspace dependencies were updated
    • dependencies
      • puppeteer-core bumped from 22.11.1 to 22.11.2

puppeteer-core: v22.11.1

22.11.1 (2024-06-17)

Bug Fixes

puppeteer: v22.11.1

22.11.1 (2024-06-17)

Miscellaneous Chores

  • puppeteer: Synchronize puppeteer versions

Dependencies

  • The following workspace dependencies were updated
    • dependencies
      • puppeteer-core bumped from 22.11.0 to 22.11.1

puppeteer-core: v22.11.0

... (truncated)

Commits
  • 92707ae chore: release main (#12606)
  • ac06674 Revert "chore(deps-dev): Bump @​swc/core from 1.5.25 to 1.6.0 in /website in t...
  • 49bcb25 fix(deps): bump ws to 8.17.1 (#12605)
  • fea43a9 chore(deps-dev): Bump the dev-dependencies group across 1 directory with 9 up...
  • a26dcfd chore(deps-dev): Bump @​swc/core from 1.5.25 to 1.6.0 in /website in the all g...
  • 0cba2b4 build: explicitly set typeRoots (#12599)
  • 9e12673 chore: release main (#12596)
  • 3874300 fix: implement nested selector parsing (#12587)
  • 80783fe fix: ensure selector parser falls back to CSS (#12585)
  • 772e088 fix: roll to Chrome 126.0.6478.61 (r1300313) (#12586)
  • Additional commits viewable in compare view
Maintainer changes

This version was pushed to npm by google-wombot, a new releaser for puppeteer since your current version.


You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

NikolaRHristov and others added 2 commits September 30, 2023 21:00
@NikolaRHristov
Make mappings and getMapping public
c389960
@dependabot
Bump ws and puppeteer
4238a17 
Bumps [ws](https://github.com/websockets/ws) to 8.17.1 and updates ancestor dependency [puppeteer](https://github.com/puppeteer/puppeteer). These dependencies need to be updated together.


Updates `ws` from 8.5.0 to 8.17.1
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](websockets/ws@8.5.0...8.17.1)

Updates `puppeteer` from 13.7.0 to 22.11.2
- [Release notes](https://github.com/puppeteer/puppeteer/releases)
- [Changelog](https://github.com/puppeteer/puppeteer/blob/main/release-please-config.json)
- [Commits](puppeteer/puppeteer@v13.7.0...puppeteer-v22.11.2)

---
updated-dependencies:
- dependency-name: ws
  dependency-type: indirect
- dependency-name: puppeteer
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jun 19, 2024
@socket-security Socket Security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] Transitive: environment, filesystem, network, shell, unsafe +114 20.4 MB

🚮 Removed packages: npm/[email protected]

View full report↗︎

@socket-security Socket Security
Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Trivial Package npm/[email protected] 🚫
Environment variable access npm/[email protected] 🚫
Trivial Package npm/[email protected] 🚫
Environment variable access npm/[email protected] 🚫
Environment variable access npm/[email protected] 🚫
Environment variable access npm/[email protected] 🚫
Filesystem access npm/[email protected] 🚫
Environment variable access npm/[email protected] 🚫
Unmaintained npm/[email protected]
  • Last Publish: 7/13/2018, 8:39:14 AM
 🚫
Unmaintained npm/[email protected]
  • Last Publish: 6/19/2018, 6:20:32 AM
 🚫
Unmaintained npm/[email protected]
  • Last Publish: 6/19/2018, 8:09:45 AM
 🚫
Trivial Package npm/[email protected] 🚫
Filesystem access npm/[email protected] 🚫
Network access npm/@tootallnate/[email protected] 🚫
Minified code npm/@tootallnate/[email protected] 🚫
Filesystem access npm/@tootallnate/[email protected] 🚫
Unmaintained npm/[email protected]
  • Last Publish: 2/13/2017, 5:14:56 PM
 🚫
Network access npm/[email protected] 🚫
Network access npm/[email protected] 🚫
Network access npm/[email protected] 🚫
Network access npm/[email protected] 🚫
Filesystem access npm/[email protected] 🚫
Filesystem access npm/[email protected] 🚫
Filesystem access npm/[email protected] 🚫
Network access npm/[email protected] 🚫
Network access npm/[email protected] 🚫
Network access npm/[email protected] 🚫
Network access npm/[email protected] 🚫
Network access npm/[email protected] 🚫
Filesystem access npm/[email protected] 🚫
Filesystem access npm/[email protected] 🚫
Network access npm/[email protected] 🚫
Network access npm/[email protected] 🚫
Network access npm/[email protected] 🚫
Network access npm/[email protected] 🚫
Network access npm/[email protected] 🚫
Network access npm/[email protected] 🚫
Network access npm/[email protected] 🚫
Filesystem access npm/[email protected] 🚫
Network access npm/[email protected] 🚫
Network access npm/[email protected] 🚫
Network access npm/[email protected] 🚫
Network access npm/[email protected] 🚫
Network access npm/[email protected] 🚫
Network access npm/[email protected] 🚫
Network access npm/[email protected] 🚫
Network access npm/[email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NikolaRHristov