Open
Conversation
Add hard polling guards and browser responsiveness checks in waitForLatestAnswer to avoid CPU spin when page.waitForTimeout returns early in zombie browser states. Also unify recoverable browser error detection and use it in BrowserSession recovery paths for ask/reset/newPage. Refs PleasePrompto#16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds DOM-based source extraction for ask_question, so citations are captured from NotebookLM’s response UI instead of asking the model to generate
them explicitly.
What changed
include_sources?: booleantoask_question.always-include-sources(default true).config set always-include-sources <true|false>include_sources(effective value used)...and “Show additional citations”.Why implement this?
Validation performed
tools/call→ `ask_question):include_sources: trueImplementation note
Since I'm not working on a project right now, I could only demonstrate it with an MVP. Further tests should be performed to ensure it does not compromise other features.
Example output
{ "success": true, "data": { "include_sources": true, "sources": [ { "title": "J.Puthiyidam and Joseph - 2023 - Prioritization of MQTT Messages A Novel Approach.pdf", "raw_text": "1: J.Puthiyidam and Joseph - 2023 - Prioritization of MQTT Messages A Novel Approach.pdf" }, { "title": "Shahri et al. - 2022 - Extending MQTT with Real-Time Communication Services Based on SDN.pdf", "raw_text": "4: Shahri et al. - 2022 - Extending MQTT with Real-Time Communication Services Based on SDN.pdf" } ] } }Branch: feat/dom-source-extraction
Commit: b898219
Issue
References #20