-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
COMP: Fix compilation on Linux with Atracsys #1127
base: master
Are you sure you want to change the base?
Conversation
A non-existent target is otherwise added to all makefiles
Are you using the latest PlusBuild with the AtracsysSDK_HOME environment variable defined? |
I believe I was, but I guess there's a possibility I was in a weird state of checkouts since I tried a couple of things first. I'll redo a clean build to make sure. |
I confirm that using the latest master branch of PlusBuild on Linux Mint (Ubuntu 22.04) results in:
And removing the offending line of the CMakeLists enables compilation. |
The AtracsysSDK_HOME variable was indeed not set at the environment level though. Why is this a new requirement? What does it need to be set to? |
It was introduced as part of this pull request (PlusToolkit/PlusBuild#93) to update for the latest SDK changes. |
Indeed, since the latest version of our SDK, we now rely on environment variables for our SDK installation. In Windows, this is automatically done in the Registry. In Linux, unfortunately, this variable needs to be manually set, as described in our user manual. |
I don't know if this line is required on Windows. I'm assuming it is (I can't test currently), so I moved it in the windows section. If not, then it could be removed entirely. On Linux it adds an non-existent object to all dependent build.make files which causes compilation to fail.