generated from PoCInnovation/open-source-project-template
-
Notifications
You must be signed in to change notification settings - Fork 0
Feat/api integration #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onfiguration and user login, still need to figure out why the created vm is not booting when using a qcow2 image
…and fixed qcow2 image problem
…ear_vm.sh in order to make a distribox image out of an ubuntu cloud image, the final distribox image
…ke a persistant connection with libvirt socket
…changing state, changed the status name to state for more clarity and coherence
…ibox into feat/api-integration
lg-epitech
approved these changes
Nov 13, 2025
Collaborator
lg-epitech
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve this is great job. Just a few notes for next time.
- Make sure the application code and messages you return are in English, I want the app to be exclusively English. I caught a french sentence in the VM_STATE_NAMES in the middle of other English statuses.
- I would like you to take a look at the PEP8 convention for python syntax and try to implement as much of it as you can. You can also look into code formatters such as autopep8 which from my recollection aren't that great, and I don't want you to take everything it gives as truth, but it's a great start to learn the conventions.
Otherwise great job.
Next features we will need that I noted were missing are:
- We need an endpoint to remove a vm from it's id
- We need an endpoint to remove the credentials assigned to a vm, also make sure the current endpoint /:vmid/password does override the current credentials if others exist.
- I will need pagination for the get_vm_list. I like verbose pagination, here is inspiration, where you create a pagination object in your json response.
GET /vms?page=2&limit=10
{
"data": [/* List of the vms of the current page */],
"pagination": {
"page": 2,
"limit": 10,
"total_items": 16,
"total_pages": 2,
}
}- In the future we will look at other endpoints to duplicate a vm or take snapshots but this is not priority
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Implemented Endpoints (Vms)